Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated set-value, mocha based on
npm audit
.1 failing test case removed:
Breaking at statement
assert(!store.hasOwn('foo\\'));
The escape behaviour is documented in set-value, but only for one set of
\\
, the old behaviour was:The behaviour with set-value updated:
I removed the test case as tests in set-value indicate that
foo\\\\.bar
should split, I assume behaviour should be consistent:Is this correct, or was there a reason for the previous behaviour? Let me know if I should do anything else.