Ignore control chars in links #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominykas
force-pushed
the
ignore-control-chars-in-links
branch
2 times, most recently
from
7056ef5
to
5f17c48
Compare
dominykas
commented
May 14, 2019
|
Thanks for preparing this fix @dominykas! What needs to happen to have this land @jonschlinkert? I'm happy to help out. |
dominykas
force-pushed
the
ignore-control-chars-in-links
branch
from
5f17c48
to
80200e3
Compare
Closes jonschlinkert#332 The code here is very similar to other markdown libraries, so I pretty much did what they do: - https://github.com/npm/marky-markdown/blob/008509231558765695938020a376b5b2e4fd4fcc/lib/gfm/override-link-destination-parser.js#L67 - https://github.com/markdown-it/markdown-it/blob/ba6830ba13fb92953a91fb90318964ccd15b82c4/lib/helpers/parse_link_destination.js#L53
dominykas
force-pushed
the
ignore-control-chars-in-links
branch
from
80200e3
to
00381e7
Compare
|
LGTM. Thanks. Will be a part of v2. |
|
Thanks |
TrySound
pushed a commit
that referenced
this pull request
Jul 29, 2019
Closes #332 The code here is very similar to other markdown libraries, so I pretty much did what they do: - https://github.com/npm/marky-markdown/blob/008509231558765695938020a376b5b2e4fd4fcc/lib/gfm/override-link-destination-parser.js#L67 - https://github.com/markdown-it/markdown-it/blob/ba6830ba13fb92953a91fb90318964ccd15b82c4/lib/helpers/parse_link_destination.js#L53
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #332
The code here is very similar to other markdown libraries, so I pretty much did what they do:
Edit: 26/Jul - rebased and updated the test fixture txt to follow latest practice