Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Release 0.1.0 #7

Closed
3 tasks done
johanjanssens opened this issue Apr 19, 2018 · 7 comments
Closed
3 tasks done

Release 0.1.0 #7

johanjanssens opened this issue Apr 19, 2018 · 7 comments
Assignees
Milestone

Comments

@johanjanssens
Copy link
Member

johanjanssens commented Apr 19, 2018

  • Finish testing and merging
  • Update version info
  • Register on packagist

Note: this release requires joomlatools/joomlatools-framework#152

@johanjanssens johanjanssens added this to the 0.1 milestone Apr 19, 2018
@johanjanssens
Copy link
Member Author

@stevenrombauts Can you register this repo on packagist?

@stevenrombauts
Copy link
Member

@johanjanssens The repository has been registered, but installing fails. Paul also confirmed this. Seems to be some Composer bug where it is comparing incorrect PHP versions, but will have to investigate further this week.

@johanjanssens
Copy link
Member Author

@stevenrombauts No problem, anything we can do on our end?

stevenrombauts pushed a commit that referenced this issue Apr 27, 2018
stevenrombauts pushed a commit that referenced this issue Apr 27, 2018
@stevenrombauts
Copy link
Member

@johanjanssens After a lot of searching and digging through errors, it seems that a couple of things are in the way.

Joomla & PHP version

First of all, Joomla's composer.json has the platform.php config option set to 5.3.10. This basically tells Composer to assume that is the actual PHP version is 5.3.10, instead of whatever the system is running on. This also requires all dependencies to work on 5.3.10. joomlatools/pages requires php >=5.5.0, so it fails.

To circumvent, we have three options:

  1. Remove the 5.5 requirement, but that seems counterproductive.
  2. Run composer install with the --ignore-platform-reqs flag, to ignore the platform.php setting.
  3. Have joomlatools/console automatically remove the platform.php setting on site:create (and make that feature a flag that is on by default, so it can still be turned off).

I'm in favour of the last option so we don't have to remember this each time we want to test something. Thoughts?

Platform & joomlatools/framework

Installing joomlatools/framework via Composer now fails on Joomlatools Platform. Have not been able to figure out why it's throwing the error that it does (it shouldn't at all). Ticket created at joomlatools/joomlatools-composer#39 to investigate further.

LDAP extension

Joomla requires php-ldap extension to be installed via joomla/ldap package. If you run a composer require on a new Joomla install, this will result in an error on the box. I don't understand why it didn't do this before, but in any case ticket joomlatools/joomlatools-vagrant#123 will remedy that by installing it by default.

Current install instructions

So, at this moment it's only possible to install on Joomla, like this:

sudo apt-get install php7.1-ldap 
joomla site:create foobar
cd /var/www/foobar
composer require --ignore-platform-reqs joomlatools/pages:dev-feature/7-release

@stevenrombauts
Copy link
Member

Forgot, to make this component installable, a manifest XML file had to be added, see commit
49ea0c5 above.

johanjanssens added a commit that referenced this issue May 3, 2018
@johanjanssens
Copy link
Member Author

@stevenrombauts Thanks for the info.

  1. Lets not complicate this, I have added instructions to the readme to include the --ignore-platform-reqs flag when installing with composer.

  2. Good catch. This is because the legacy libs are not loaded. This is being resolved here: Use JEventDispatcher instead of deprecated JDispatcher joomlatools-framework#159

  3. Oki, suggest we do a maintenance release of the vagrant box to resolve this asap?

johanjanssens added a commit that referenced this issue May 3, 2018
johanjanssens added a commit that referenced this issue May 7, 2018
@johanjanssens
Copy link
Member Author

@ercanozkaya Can you try to build a package including the framework? i would like to have this easily installable. Please also check if all the info is there for the 0.1.0 release

ercanozkaya added a commit that referenced this issue May 7, 2018
ercanozkaya added a commit that referenced this issue May 7, 2018
ercanozkaya added a commit that referenced this issue May 7, 2018
ercanozkaya added a commit that referenced this issue May 7, 2018
ercanozkaya added a commit that referenced this issue May 7, 2018
ercanozkaya added a commit that referenced this issue May 7, 2018
@johanjanssens johanjanssens changed the title Prepare 0.1 release Prepare 0.1.0 release Aug 3, 2018
@johanjanssens johanjanssens changed the title Prepare 0.1.0 release Release 0.1.0 Sep 5, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants