This repository has been archived by the owner on Aug 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 777
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(builtins): handle buf's lack of stdin support
See this issue for info: bufbuild/buf#1035 For formatting, the fix is to write to and read from a temp file. Diagnostics require project context, which a temp file can't provide, so the diagnostics source now runs only on save.
- Loading branch information
Jose Alvarez
committed
May 22, 2022
1 parent
27e0dfc
commit 558415e
Showing
2 changed files
with
5 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
558415e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for the fix! Should this be undone once
buf
supports stdin? I can keep an eye out for it.558415e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, thanks - moving back to
stdin
would be ideal once it's supported.