Refactored MysqlEngine, created PdoEngine, added Postgres support #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josegonzalez The PdoEngine refactoring and Postgres support is done, would be great if you could give it a look. I'm not sure what to do about the coveralls error - because effectively, test coverage didn't decrease. |
| } | ||
|
|
||
| /** | ||
| * @covers josegonzalez\Queuesadilla\Engine\PdoEngine::connect |
There was a problem hiding this comment.
I think the reason test coverage went down is that the MysqlEngine is no longer covered here.
|
Here we go :) |
| @@ -229,22 +229,17 @@ public function quoteIdentifier($identifier) | |||
| return $this->startQuote . $identifier . $this->endQuote; | |||
| } | |||
|
|
|||
| // string.string | |||
There was a problem hiding this comment.
Why not instead pull the regex out into a variable? That should help explain what the regex is for.
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #30