-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
\insertframetitle can't be used inside \MakeUppercase if there is a framebreak. #802
Comments
…d with \MakeUppercase (fix josephwright#802)
@u-fischer Thanks for reporting! |
Reopening this issue for now as this would break the metropolis theme. The proposed fix is stored in https://github.com/josephwright/beamer/tree/802-Uppercase-frametitle and a PR is opened for metropolis at matze/mtheme#391 |
The Trigon theme suffers from the same problem. I left a heads-up issue at https://gitlab.com/thlamb/beamertheme-trigon/-/issues/7 Update: The author is informed and very helpfully agreed to prepare an update for when this goes live for beamer. Half of the problem solved :) |
@josephwright There seems to be no reaction from metropolis, so I was looking into your suggestion of doing some first aid via filehooks. My current approach is to revert back to the old definition before metropolis, let it patch whatever it wants and then overwrite the definition again at the end of the file. Is this what you had in mind or is there some better solution?
|
@samcarter Looks good to me |
@josephwright Thanks! I'll merge the changes |
@josephwright Could you coordinate with @lambtho12 about the timing of the next release so that the trigon theme can be updated accordingly? |
I will prepare the patch for Trigon sometime next week in a separate branch. |
FYI, Trigon patch is ready. I will merge as soon as new version of beamer hits CTAN. |
@lambtho12 FYI: Joseph released beamer v3.69 2023-02-20 earlier today. It should currently make its way around the ctan mirrors and be available there within the next 24 hours or so. |
Awesome. Thanks for the notif. I will package an publish Trigon this evening after work. |
Just published fix on CTAN as well. Works as expected with latest Beamer. |
The definition of
\insertframetitle
tries to call a template if a framebreak is detected, and this breaks in\MakeUppercase
.Perhaps the definition could be made more safe by protecting the template with a
\CaseSwitch
?The text was updated successfully, but these errors were encountered: