Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add TinyMCEEditorField #131

Merged
merged 4 commits into from
Mar 23, 2023
Merged

Add TinyMCEEditorField #131

merged 4 commits into from
Mar 23, 2023

Conversation

sinisaos
Copy link
Contributor

Related to #130

Copy link
Owner

@jowilf jowilf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work, Please check my comments

starlette_admin/templates/forms/tinymce.html Outdated Show resolved Hide resolved
starlette_admin/fields.py Outdated Show resolved Hide resolved
starlette_admin/templates/forms/tinymce.html Outdated Show resolved Hide resolved
@jowilf
Copy link
Owner

jowilf commented Mar 23, 2023

Thank you for your contribution, I will add a couple of things and merge it

@jowilf jowilf changed the title Add optional TinyMCEEditorField Add TinyMCEEditorField Mar 23, 2023
@jowilf jowilf linked an issue Mar 23, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.07 ⚠️

Comparison is base (7126634) 100.00% compared to head (b48716c) 99.93%.

❗ Current head b48716c differs from pull request most recent head 022f6aa. Consider uploading reports for the commit 022f6aa to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #131      +/-   ##
===========================================
- Coverage   100.00%   99.93%   -0.07%     
===========================================
  Files           62       62              
  Lines         4452     4460       +8     
===========================================
+ Hits          4452     4457       +5     
- Misses           0        3       +3     
Impacted Files Coverage Δ
starlette_admin/fields.py 99.39% <66.66%> (-0.61%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jowilf jowilf merged commit 812526f into jowilf:main Mar 23, 2023
@sinisaos sinisaos deleted the tinymce_field branch March 23, 2023 06:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Optional WYSIWYG editor for TextAreaField
2 participants