Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Compatibility check and testing for Node.js 14 and 16 #30

Closed
ioBrokerChecker opened this issue May 5, 2021 · 5 comments
Closed

Compatibility check and testing for Node.js 14 and 16 #30

ioBrokerChecker opened this issue May 5, 2021 · 5 comments

Comments

@ioBrokerChecker
Copy link

Dear Adapter develop,

Node.js 14 is now available for a year and Node.js 16 was release just some days ago and will become LTS by October 2021. We plan to update the ioBroker Node.js recommendation (currently 12.x) to 14.x later this year.

Please check your adapter with Node.js 14 especially, and ideally also directly with Node.js 16

Please add both versions to the adapter testing which is executed on commits.

If your adapter requires a certain minimum version of Node.js please set the 'engine' setting in package.json accordingly! Please also do this if the adapter is not able to work in certain Node.js versions, so that ioBroker can prevent users from installing te adapter if not compatible!

On questions please talk to us at ioBroker/ioBroker.js-controller#1138

Please close the issue after you checked it.

Thank you very much for your support!
@jpgorganizer
Copy link
Owner

see ioBroker/ioBroker.js-controller#1138 (comment)

@Apollon77
Copy link
Contributor

answered :-)

@jpgorganizer
Copy link
Owner

node.js 14 worked out of box
node.js 16 test pending

@jpgorganizer
Copy link
Owner

jpgorganizer commented May 7, 2021 •
edited
Loading

node.js 14 worked out of box
node.js 16 test pending

node.js 16 worked out of box

done with versions

  • admin 4.2.1
  • js-controller 3.3.8
  • Node.js: v12.22.1
  • NPM: v6.14.12

Travis test added

jpgorganizer added a commit that referenced this issue May 13, 2021
@jpgorganizer
v1.0.5
a20795d 
  - adjustments due to js-controller v3.3; e.g. [Issue 29](#29)
  - compatibility test with node.js v14/v16 and with the upcoming Admin 5 React UI e.g. [Issue 30](#30)
  - new parameter *beautify log* in instance configuration
@jpgorganizer
Copy link
Owner

solved with v1.0.5

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Apollon77 @ioBrokerChecker @jpgorganizer