Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test comparison table #1958

Merged
merged 7 commits into from
Sep 6, 2024
Merged

Test comparison table #1958

merged 7 commits into from
Sep 6, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Sep 1, 2024

This PR adds test for the comparison table and its filter.

In the filter we test, that the search string (de-)anonymizes correctly and that metric changes get correctly given to the store.

In the table we check that all filtering in the search bar has the desired effect. We test taht the header prop is displayed correctly. We check that sorting works as expected.

(Tests will work after merging of #1959)

@Kr0nox Kr0nox mentioned this pull request Sep 2, 2024
6 tasks
@Kr0nox Kr0nox changed the title Test comparison table filter Test comparison table Sep 2, 2024
Copy link

sonarcloud bot commented Sep 3, 2024

Quality Gate Failed Quality Gate failed for 'JPlag Report Viewer'

Failed conditions
21.7% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

@Kr0nox Kr0nox marked this pull request as ready for review September 3, 2024 06:57
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Sep 6, 2024
@tsaglam tsaglam merged commit 8f28934 into develop Sep 6, 2024
50 of 51 checks passed
@tsaglam tsaglam deleted the report-viewer/comparison-table-test branch September 6, 2024 06:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants