Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

eyeball-im: Switch to imbl #10

Merged
merged 1 commit into from
Mar 16, 2023
Merged

eyeball-im: Switch to imbl #10

merged 1 commit into from
Mar 16, 2023

Conversation

jplatte
Copy link
Owner

@jplatte jplatte commented Mar 16, 2023

Closes #9.

cc @vlmutolo

Hywan
Hywan approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about re-exporting imbl (with maybe another name) from eyeball, so that's dependencies of eyeball doesn't break when such a change happens :-)

@jplatte
Copy link
Owner Author

jplatte commented Mar 16, 2023

Well it's a public dependency either way, but yeah I actually thought about that as well. I'd like to be conservative and only re-export the types that appear in eyeball-ims API though.

@jplatte jplatte merged commit d86f7ca into main Mar 16, 2023
@jplatte jplatte deleted the imbl branch March 16, 2023 14:48
@jplatte
Copy link
Owner Author

jplatte commented Mar 16, 2023

Published as eyeball-im 0.2.0, including a Vector re-export at the crate root.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Hywan Hywan Hywan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider switching from im to imbl for immutable data structures
2 participants
@jplatte @Hywan