Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added versions of createReverse able to preserve tags of entries #159

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Added versions of createReverse able to preserve tags of entries #159

merged 2 commits into from
Jun 22, 2020

Conversation

alcarraz
Copy link
Contributor

closes #158 Create versions of GLTransaction.createReverse(...) that preserve tags for created reversal entries

Also:

  • cleaned up some unnecessary code
  • fixed minigl TestBase: Export needs test user, this wasn't giving trouble from gradle but yes when run as a standalone test, thing is export also needs valid user with read permissions.

Andrés Alcarraz added 2 commits June 19, 2020 19:41
minigl TestBase: Export needs test user.
8e875a2
Added versions of createReverse able to preserve tags of entries
12ba9b3 
Also remove some unnecesary code

jpos#158 Create version of GLTransaction.createReverse(...)  that preserve tags for created reversal entries
@ar ar merged commit be4ab0e into jpos:master Jun 22, 2020
@alcarraz alcarraz deleted the issue/158-preserve-entry-tags-on-create-reversals branch June 23, 2020 01:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create version of GLTransaction.createReverse(...) that preserve tags for created reversal entries
2 participants
@alcarraz @ar