Wait for all session workers to finish

[alcarraz]

before shutting down the server.

When sessions property was greater than one, the first to end was shutting down the Q2 server whether the others have finished or not.

[ar]

Great PR that addresses a real problem, and I love latches as it reminds me TTL logic days, but couldn't you just awaitTermination on the executor?

[alcarraz]

Great PR that addresses a real problem, and I love latches as it reminds me TTL logic days, but couldn't you just awaitTermination on the executor?

As a matter of fact, that was my first approach. It was failing for an unrelated issue (some silly error of mine relating to setting the timeout variable in the wrong place) and while debugging that issue, I added the latch. I was debating with myself about leaving the latch or get back to using the executor's awaitTermination. Somehow I believed the latch could provide a clearer intention, but I'm with you in that less is more.

[alcarraz]

FYI, suggested change has already been pushed to the PR.

Great PR that addresses a real problem, and I love latches as it reminds me TTL logic days, but couldn't you just awaitTermination on the executor?

As a matter of fact, that was my first approach. It was failing for an unrelated issue (some silly error of mine relating to setting the timeout variable in the wrong place) and while debugging that issue, I added the latch. I was debating with myself about leaving the latch or get back to using the executor's awaitTermination. Somehow I believed the latch could provide a clearer intention, but I'm with you in that less is more.