Implement TriggerListener #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At times its possible trigger doesn't fire (quartz calls it mis-fire)and we need to log it else we may just not know when a job isn't performed. Mis-fire handling instructions need to be provided at trigger creation time (withMisfireHandlingInstructionFireAndProceed). Also helpful to log when the trigger is fired and completed(part of TriggerListener implementation) along with info when it will get triggered again.
Manual edit added an extra bracket
|
You should add |
chhil
added a commit
to chhil/jPOS-EE
that referenced
this pull request
Dec 19, 2020
The startservice was missing the registering of the trigger. I have this in my prod code, its somehow got missed in the jpos#82
You are correct, for some reason it did not get added in this PR (most likely due to me running on older versions of jpos and copy pasting the code directy into github editor). . I have this running in prod code. |
|
Your |
|
What do I need to do to |
|
I believe you need to |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At times its possible trigger doesn't fire (quartz calls it mis-fire)and we need to log it else we may just not know when a job isn't performed.
Mis-fire handling instructions need to be provided at trigger creation time (withMisfireHandlingInstructionFireAndProceed).
Also helpful to log when the trigger is fired and completed(part of TriggerListener implementation) along with info when it will get triggered again.