Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ensureSymlink silently exits if the destination exists and is not a symlink #786

Closed
CxRes opened this issue Apr 1, 2020 · 1 comment · Fixed by #826
Closed

ensureSymlink silently exits if the destination exists and is not a symlink #786

CxRes opened this issue Apr 1, 2020 · 1 comment · Fixed by #826
Labels
bug semver-major
Milestone
10.0.0

Comments

@CxRes
Copy link

CxRes commented Apr 1, 2020

Looking into the code, I found that ensure* methods only verify if the destination path exist and not if the path is of the right * type. IMHO an error should be thrown if path is of the wrong type. Perhaps fs.stat instead of fs.access should suffice...
@RyanZim
Copy link
Collaborator

RyanZim commented Jun 3, 2020

Yep, ensureFile has checks in place, but it looks like Link/Symlink don't. Milestoning for v10 since this would be a breaking change, technically.

@RyanZim RyanZim added this to the 10.0.0 milestone Jun 3, 2020
RyanZim added a commit that referenced this issue Jul 29, 2020
@RyanZim
BREAKIN: Error if destination wrong type for ensureLink/Symlink
7926e66 
Fixes #786
RyanZim added a commit that referenced this issue Jul 29, 2020
@RyanZim
BREAKING: Error if destination wrong type for ensureLink/Symlink
eae5c33 
Fixes #786
@RyanZim RyanZim mentioned this issue Jul 29, 2020
Merged
This was referenced Feb 22, 2021
Closed
Merged
RyanZim added a commit that referenced this issue Apr 1, 2021
@RyanZim
BREAKING: Ensure existing dest correct type/target in ensureLink/Symlink
fa64be8 
Fixes #786
Fixes #870
RyanZim added a commit that referenced this issue Apr 2, 2021
@RyanZim
BREAKING: Ensure existing dest correct type/target in ensureLink/Syml…
4523526 
…ink (#826)

Fixes #786
Fixes #870
@sync-by-unito sync-by-unito bot mentioned this issue Jun 9, 2021
Closed
@mfranzke mfranzke mentioned this issue Jun 24, 2021
Merged
78 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug semver-major
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

BREAKING: Ensure existing dest correct type/target in ensureLink/Symlink jprichardson/node-fs-extra
2 participants
@CxRes @RyanZim