-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
BREAKING: Do not error when copy destination exists & clobber: false #330
Conversation
Hold off on this, copySync needs edited too. |
Add errorOnExist option for users that want an error Resolves #321
c09ca54
to
3fa83d4
Compare
copySync updated. |
@jprichardson I think this is merge-ready, just want you to approve the error message first. |
Awesome, thanks! |
Just a thought - do you think throwing the same style error messages as Meaning that instead of |
@callodacity We've discussed this before, I don't think replicating fs errors is a good practice.
|
@RyanZim both good points, and I agree with you completely. However, the only thing I see as an issue is that in order to check if the error thrown is the |
Add errorOnExist option for users that want an error
Resolves #321
@jprichardson What do you think of the error message?