Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

allow preserveTimestamps when use move #342

Closed
wants to merge 6 commits into from

Conversation

bluelovers
Copy link

allow preserveTimestamps when use move
default: true

@jdalton
Copy link
Contributor

jdalton commented Mar 7, 2017

@bluelovers Could you rebase this PR please.

@bluelovers
Copy link
Author

updated merge

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 79.236% when pulling caed5a1 on bluelovers:develop into 9bef553 on jprichardson:master.

@bluelovers
Copy link
Author

@jdalton thx

@RyanZim
Copy link
Collaborator

RyanZim commented Mar 7, 2017

@jprichardson Is this something you'd be interested in adding?


@bluelovers If we add this, this will need tests. Also, if #381 is merged ahead of this, equivalent functionality will need to be added to moveSync.

@bluelovers
Copy link
Author

i have noidea how to make a good test lol

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 79.308% when pulling 436a674 on bluelovers:develop into 9bef553 on jprichardson:master.

@jprichardson
Copy link
Owner

@jprichardson Is this something you'd be interested in adding?

Yeah, I think it's worth it.

@RyanZim
Copy link
Collaborator

RyanZim commented Mar 8, 2017

OK, if the code looks good to you, I'll squash-merge this.

@jprichardson
Copy link
Owner

OK, if the code looks good to you, I'll squash-merge this.

SGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+1.0%) to 80.498% when pulling edc5070 on bluelovers:develop into 9bef553 on jprichardson:master.

@RyanZim
Copy link
Collaborator

RyanZim commented May 22, 2019

This looks like it might be conflicted beyond repair, any opposed to closing?

@RyanZim RyanZim closed this Jan 30, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants