-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Allow copy's filter to return a Promise #518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good @RyanZim! But, you mean we don't need to check if we have a filter opt at all? I mean calling Promise.resolve
without checking whether we need to call it or not, wouldn't affect the perf for the cases that we don't have a filter opt?!
@manidlou Good point about the perf; wouldn't have much impact if we're just calling a noop function, but with the extra |
f2c043d
to
9732252
Compare
Updated & fixed merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
No description provided.