Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade golang.org/x/sys so it builds with Go 1.18 #3

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Upgrade golang.org/x/sys so it builds with Go 1.18 #3

merged 1 commit into from
Apr 19, 2022

Conversation

brettbuddin
Copy link
Contributor

@brettbuddin brettbuddin commented Apr 10, 2022

I pulled this down to install it on my M1 Mac, and discovered that it fails to build with Go 1.18 due to a common issue with golang.org/x/sys. I've upgraded it here so things build.

Here's the failure this corrects:

# golang.org/x/sys/unix
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/syscall_darwin.1_13.go:29:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.1_13.go:27:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.1_13.go:40:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.go:28:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.go:43:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.go:59:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.go:75:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.go:90:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.go:105:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.go:121:3: //go:linkname must refer to declared function or variable
../../../go/pkg/mod/golang.org/x/sys@v0.0.0-20200622214017-ed371f2e16b4/unix/zsyscall_darwin_arm64.go:121:3: too many errors

📎 golang/go#51091

@jpriebe
Copy link
Owner

jpriebe commented Apr 19, 2022

Thanks, Brett!

@jpriebe jpriebe merged commit 6458a06 into jpriebe:master Apr 19, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants