Skip to content

Re-add support for Swift Package Manager #267

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Oct 18, 2016
Merged

Re-add support for Swift Package Manager #267

merged 6 commits into from
Oct 18, 2016

Conversation

jpsim
Copy link
Owner

@jpsim jpsim commented Oct 13, 2016

Targets and depends on #264.

@jpsim jpsim changed the base branch from jp-swift-3-api-guidelines to master October 18, 2016 00:39
@jpsim
Copy link
Owner Author

jpsim commented Oct 18, 2016

This has been rebased on master after #273 was merged. Thoughts @norio-nomura?

@norio-nomura
Copy link
Collaborator

It may be ok if ci will pass. 👍

BTW, I feel "Squash and merge” or “Rebase and merge” are making hard to rebasing another working branches…

@jpsim
Copy link
Owner Author

jpsim commented Oct 18, 2016

BTW, I feel "Squash and merge” or “Rebase and merge” are making hard to rebasing another working branches…

Yes, that may be what caused the issues with #273 😬. I've disabled the "Squash and merge" option, as I think that's what was causing issues. I think "Rebase and merge" should be fine.

@norio-nomura
Copy link
Collaborator

I've disabled the "Squash and merge" option, as I think that's what was causing issues.

Thank you! 🙏

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants