Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update auditwheel command to use --exclude #132

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

devinrsmith
Copy link
Member

The internal structure of auditwheel has changed with the 6.0.0 release, causing our current script to break:

Traceback (most recent call last):
  File "/home/runner/work/jpy/jpy/.github/env/Linux/auditwheel-keep-libjvm.py", line 4, in <module>
    from auditwheel.policy import _POLICIES
ImportError: cannot import name '_POLICIES' from 'auditwheel.policy' (/opt/hostedtoolcache/Python/3.12.2/x64/lib/python3.12/site-packages/auditwheel/policy/__init__.py)

This PR fixes that by relying on the command line --exclude flag.

Very similar to PR from deephaven/deephaven-server-docker#83

https://github.com/pypa/auditwheel/releases/tag/6.0.0

The internal structure of auditwheel has changed with the 6.0.0 release, causing our current script to break:

```
Traceback (most recent call last):
  File "/home/runner/work/jpy/jpy/.github/env/Linux/auditwheel-keep-libjvm.py", line 4, in <module>
    from auditwheel.policy import _POLICIES
ImportError: cannot import name '_POLICIES' from 'auditwheel.policy' (/opt/hostedtoolcache/Python/3.12.2/x64/lib/python3.12/site-packages/auditwheel/policy/__init__.py)
```

This PR fixes that by relying on the command line `--exclude` flag.

Very similar to PR from deephaven/deephaven-server-docker#83

https://github.com/pypa/auditwheel/releases/tag/6.0.0
@devinrsmith devinrsmith requested a review from jmao-denver March 12, 2024 18:18
@devinrsmith devinrsmith self-assigned this Mar 12, 2024
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devinrsmith devinrsmith merged commit 03e5316 into jpy-consortium:master Mar 12, 2024
27 checks passed
@devinrsmith devinrsmith deleted the update-auditwheel branch March 13, 2024 00:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants