Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added is{scalar,value,..}. Fixes leaf_paths bug. #1178

Closed
wants to merge 0 commits into from

Conversation

alex-ozdemir
Copy link
Contributor

Now paths to false leaves are correctly returned.
Added the new test functions to the docs.

@alex-ozdemir
Copy link
Contributor Author

This is a partial solution to #1163.

@alex-ozdemir alex-ozdemir mentioned this pull request Jul 6, 2016
@coveralls
Copy link

coveralls commented Jul 6, 2016

Coverage Status

Coverage increased (+0.07%) to 85.402% when pulling dc9d437 on alex-ozdemir:master into 0b82185 on stedolan:master.

@ghost
Copy link

ghost commented Jul 6, 2016

I proposed something very similar a long time ago. I like it! I find myself using type == "array" more often than arrays.

@coveralls
Copy link

coveralls commented Jul 6, 2016

Coverage Status

Coverage increased (+0.5%) to 85.839% when pulling 22a0a67 on alex-ozdemir:master into 0b82185 on stedolan:master.

@coveralls
Copy link

coveralls commented Jul 6, 2016

Coverage Status

Coverage remained the same at 85.333% when pulling c87889e on alex-ozdemir:master into 0b82185 on stedolan:master.

@alex-ozdemir
Copy link
Contributor Author

Okay, paths to null handled by fixing paths. The fix uses an alternative behavior for recurse. I chose not to include this new behavior in the stdlib, as having two floating around would probably just confuse people.

This PR now completely closes #1163.

@coveralls
Copy link

coveralls commented Jul 7, 2016

Coverage Status

Coverage remained the same at 85.333% when pulling cc573c4 on alex-ozdemir:master into 0b82185 on stedolan:master.

@nicowilliams
Copy link
Contributor

Thanks! I'll review.

@nicowilliams nicowilliams self-requested a review December 14, 2017 21:26
@alex-ozdemir
Copy link
Contributor Author

Paging @nicowilliams 😄

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants