-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fedora link returns 404 #2067
Fedora link returns 404 #2067
Conversation
Updated with correct path
@@ -24,7 +24,7 @@ body: | |||
`sudo apt-get install jq`. | |||
|
|||
* jq 1.5 is in the official |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually at 1.6.4 now in Fedora 32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't released any revisions to 1.6- that -4
is referring to the version of the RPM itself. That said, this should say 1.6 instead of 1.5. Mind updating it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wtlangford , since this seems to be a dead PR. I've confirmed here https://src.fedoraproject.org/rpms/jq/blob/master/f/sources that Fedora is using jq v1.6
* jq 1.5 is in the official | |
* jq 1.6 is in the official |
Can you accept the GH suggestion and we get this closed, or would you prefer I make a new PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't released any revisions to 1.6- that
-4
is referring to the version of the RPM itself. That said, this should say 1.6 instead of 1.5. Mind updating it?
Apologies, I thought I had already done the update and you had to accept the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, I thought I had already done the update and you had to accept the PR?
@calpeconsulting The change in the PR still refers to jq 1.5. It needs to be jq 1.6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you. This PR aims to fix the dead link, and versions can be fixed separately (we may drop mentioning versions each package managers).
Updated with correct path