Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

C99 compatibility enhancements for the configure script #2519

Merged
merged 2 commits into from
Jun 14, 2023
Merged

C99 compatibility enhancements for the configure script #2519

merged 2 commits into from
Jun 14, 2023

Conversation

fweimer-rh
Copy link
Contributor

@liquidaty liquidaty mentioned this pull request Mar 7, 2023
Closed
@thesamesam
Copy link

Duplicate of #2480?

@fweimer-rh
Copy link
Contributor Author

@thesamesam Looks like I didn't scroll down far enough in the PR list. But this PR here proposes to use AC_USE_SYSTEM_EXTENSIONS, which is the currently recommended autoconf way.

@thesamesam
Copy link

thesamesam commented Mar 9, 2023 •
edited
Loading

I only found that one accidentally too. Yeah, I prefer the approach in this one.

cc @kraj, are you alright to close yours?

@kraj
Copy link

kraj commented Mar 9, 2023

Yes this is clearly better way please go ahead

@itchyny itchyny added the build label Jun 3, 2023
@itchyny
Copy link
Contributor

itchyny commented Jun 13, 2023

Would you rebase against the latest master, since this is a fix to a building script? Thank you.

@fweimer-rh
configure.ac: Enable system extensions
c76d059 
Use AC_USE_SYSTEM_EXTENSIONS to build with _GNU_SOURCE (and similar
macros on non-GNU systems), to avoid an implicit declaration of the
strptime function.  This improves compatibility with future compilers
which do not support implicit function declarations.
@fweimer-rh
configure.ac: gettimeofday lives in <sys/time.h>
f347bad 
The gettimeofday function is declared in <sys/time.h>, not <time.h>,
according to POSIX and actual systems.  This avoids a configure
probe failure with compilers which do not support implicit function
declarations.
@fweimer-rh
Copy link
Contributor Author

@itchyny Should now be properly rebased.

itchyny
itchyny approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@itchyny itchyny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@itchyny itchyny merged commit 52d5988 into jqlang:master Jun 14, 2023
@itchyny itchyny mentioned this pull request Jun 14, 2023
Closed
@emanuele6 emanuele6 mentioned this pull request Jul 13, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@itchyny itchyny itchyny approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fweimer-rh @thesamesam @kraj @itchyny