Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix some gsub bugs (incremental changes only); clarify gsub documentation #2621

Closed
wants to merge 2 commits into from
Closed

fix some gsub bugs (incremental changes only); clarify gsub documentation #2621

wants to merge 2 commits into from

Conversation

pkoppstein
Copy link
Contributor

  1. Let sub/2 stand
  2. Incremental enhancements of sub/3 to resolve some important gsub bugs including gsub loops infinitely with "^" or "" #2148 gsub lookahead cannot allocate memory #2354 gsub with empty regex doesn't terminate #1206
  3. Augment tests in onig.test
  4. Tweak documentation of gsub

Note that these updates do not address the issue raised (for example) in #1425

@pkoppstein
fix some gsub bugs (incremental changes only); clarify gsub documenta…
4b981d1 
…tion

1) Let sub/2 stand
2) Incremental enhancements of sub/3 to resolve some important gsub bugs including #2148 #2354 #1206
3) Augment tests in onig.test
4) Tweak documentation of gsub

Note that these updates do not address the issue raised (for example) in #1425
@pkoppstein pkoppstein mentioned this pull request Jun 19, 2023
Closed
@itchyny itchyny added the bug label Jun 19, 2023
@pkoppstein
Copy link
Contributor Author

better fix is in the works

@pkoppstein pkoppstein closed this Jun 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkoppstein @itchyny