Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Simple and efficient implementation of walk/1 #2795

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

pkoppstein
Copy link
Contributor

Resolves #2584; also resolves #2611
and supersedes #2655

Note that according to the revised implementation:

{x:0} | walk(.,1) is equivalent to {x:0} | walk(.), walk(1)

Resolves jqlang#2584; also resolves jqlang#2611
and supersedes jqlang#2655

Note that according to the revised implementation:

`{x:0} | walk(.,1)` is equivalent to `{x:0} | walk(.), walk(1)`
@pkoppstein pkoppstein mentioned this pull request Jul 31, 2023
@itchyny itchyny changed the title builtin.jq: revamp walk/1 Simple and efficient implementation of walk/1 Jul 31, 2023
@itchyny itchyny added this to the 1.7 release milestone Jul 31, 2023
Copy link
Contributor

@itchyny itchyny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itchyny itchyny merged commit 4d4c17c into jqlang:master Jul 31, 2023
@pkoppstein
Copy link
Contributor Author

@itchyny - Thanks. Sorry about the rebase problem. I just used the "Rebase" button on GitHub Desktop, followed by "Push".

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ER: simpler, faster walk/1 Deleting objects using walk has side effects
2 participants