-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ajaxSubmit is not encoding newlines as CRLF pairs, but only as LF #517
Comments
This looks related to #158. How do you compare your fix vs @cgi-caesar's? Should we implement both of your changes, or would that break things further? |
I think that it makes sense of using only the jQuery method for serializing arrays as it is doing other stuffs as well and if there are changes later to it we will get automatically an updated version and only jQuery will be responsible for the encoding and not jQuery-form anymore. I don't think that for this case we need both issues, one of those should be sufficient, but I would prefer using the serializeArray jQuery method and letting all the responsibility to jQuery. Implementing both solutions should not break things further, but it will add additional overhead. I would say it is up to the maintainer to decide, which is better :). |
per the application/x-www-form-urlencoded specification #158 #421 #516 #517 Follows jQuery's lead: jquery/jquery@eed3803 5bf81154
While I agree with you that using jQuery's serializeArray() potentially makes sense in the long term, it would fundamentally change how the form plugin is serializing the form today. a = this.serializeArray(this.formToArray(options.semantic, elements, options.filtering)); jQuery.serializeArray() takes no arguments, so I think the result of this.formToArray() is being thrown away in favor of jQuery's serialization. This means that the I have merged a modified version of @cgi-caesar's PR #421 that is consistent with jQuery's serialization source. |
v4.1.0 has been released with this change. |
@see pull request #516
The text was updated successfully, but these errors were encountered: