Shallow options #193
Closed
Shallow options #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semantics mostly the same, but without cloning anything but plain objects, e.g. not cloning of arrays
| $.widget.extend(settings, options); | ||
| same( settings, merged, "Check if extended: settings must be extended" ); | ||
| same( options, optionsCopy, "Check if not modified: options must not be modified" ); | ||
| $.widget.extend(settings, null, options); |
There was a problem hiding this comment.
I'm confused what's being tested here. settings has already been extended with options at this point, so the next assertion should be true even if no merging occurs here.
|
Updated. |
|
Another update. |
|
Okay, now there is another update. Including messed up commit message.. |
|
Landed in b915325. I switched back to $.extend() on the constructor, since that doesn't deal with options, also removed the test for extending functions, since that shouldn't occur in options. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue of $.widget deep copying all options, which is a problem when dealing with large arrays, both for performance and identity reasons.
The tests are mostly taken from jQuery core's testsuite to maintain compability, with the exception of not deep-copying arrays, just plain objects.