Updates for LLVM10 #185
Merged
Updates for LLVM10 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, for the CI see |
jrprice
requested changes
May 27, 2020
|
CI after latest changes: EDIT: Just realized there's already a Travis run just below. Don't know how I missed that before! :) |
jrprice
approved these changes
May 31, 2020
|
Looks good, thanks! |
|
@alexfikl Do you still need LLVM 10 support in Oclgrind now that LLVM 11 has been released? I'm working on adding support for LLVM 11 right now, but supporting older versions has become awkward due to changes in the vector type APIs, so I'm strongly considering dropping support for everything older than 11. |
|
I'm fine with moving to LLVM 11+ only. Thank you for asking! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code changes required for LLVM10 seem to be fairly trivial. I'm not knowledgeable, so they might not be quite right (beyond compiling).
I also made some more non-trivial changes to the buildsystem/CI to test out that everything still works. It seems to build and pass tests on the CI and locally, but let me know if it can be improved!