Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move annotation to a different category #229

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions backend/webserver/api/annotations.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
create_annotation.add_argument('keypoints', type=list, location='json')
create_annotation.add_argument('color', location='json')

update_annotation = reqparse.RequestParser()
update_annotation.add_argument('category_id', type=int, location='json')

@api.route('/')
class Annotation(Resource):
Expand Down Expand Up @@ -90,6 +92,24 @@ def delete(self, annotation_id):
set__deleted_date=datetime.datetime.now())
return {'success': True}

@api.expect(update_annotation)
@login_required
def put(self, annotation_id):
""" Updates an annotation by ID """
annotation = current_user.annotations.filter(id=annotation_id).first()

if annotation is None:
return { "message": "Invalid annotation id" }, 400

args = update_annotation.parse_args()

new_category_id = args.get('category_id')
annotation.update(category_id=new_category_id)
logger.info(
f'{current_user.username} has updated category for annotation (id: {annotation.id})'
)
newAnnotation = current_user.annotations.filter(id=annotation_id).first()
return query_util.fix_ids(newAnnotation)

# @api.route('/<int:annotation_id>/mask')
# class AnnotationMask(Resource):
Expand Down
42 changes: 35 additions & 7 deletions client/src/components/annotator/Annotation.vue
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
<option :value="1">LABELED NOT VISIBLE</option>
<option :value="2">LABELED VISIBLE</option>
</select>
</div>
</div>
</div>
</form>
</div>
Expand Down Expand Up @@ -136,19 +136,31 @@
<div class="modal-body">
<form>
<div class="form-group row">
<label class="col-sm-2 col-form-label">Color</label>
<div class="col-sm-9">
<label class="col-sm-3 col-form-label">Color</label>
<div class="col-sm-8">
<input v-model="color" type="color" class="form-control" />
</div>
</div>

<div class="form-group row">
<label class="col-sm-2 col-form-label">Name</label>
<div class="col-sm-9">
<label class="col-sm-3 col-form-label">Name</label>
<div class="col-sm-8">
<input v-model="name" class="form-control" />
</div>
</div>

<div class="form-group row">
<label class="col-sm-3 col-form-label">Category</label>
<div class="col-sm-8">
<select class="form-control" @change="setCategory">
<option
v-for="option in allCategories"
:selected="annotation.category_id === option.value"
:key="option.text"
>
{{ option.text }}
</option>
</select>
</div>
</div>
<Metadata
:metadata="annotation.metadata"
ref="metadata"
Expand Down Expand Up @@ -236,6 +248,10 @@ export default {
activeTool: {
type: String,
required: true
},
allCategories: {
type: Array,
default: () => []
}
},
data() {
Expand Down Expand Up @@ -582,6 +598,18 @@ export default {
this.compoundPath.fillColor = this.color;
this.keypoints.color = this.darkHSL;
},
setCategory(event) {
const newCategoryName = event.target.value;
const annotation = this.annotation;
const oldCategory = this.$parent.category;

this.$parent.$parent.updateAnnotationCategory(
annotation,
oldCategory,
newCategoryName
);
$(`#annotationSettings${annotation.id}`).modal("hide");
},
export() {
if (this.compoundPath == null) this.createCompoundPath();

Expand Down
13 changes: 11 additions & 2 deletions client/src/components/annotator/Category.vue
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@
:active-tool="activeTool"
:scale="scale"
@deleted="annotationDeleted"
:all-categories="getCategoriesList"
/>

</ul>

<div
Expand Down Expand Up @@ -131,7 +131,6 @@
</div>
</div>
</div>

</div>
</template>

Expand Down Expand Up @@ -181,6 +180,10 @@ export default {
activeTool: {
type: String,
required: true
},
allCategories: {
type: Array,
required: true
}
},
data: function() {
Expand Down Expand Up @@ -393,6 +396,12 @@ export default {
if (search.length === 0) return true;
return this.category.name.toLowerCase().includes(search);
},
getCategoriesList() {
return this.allCategories.map(category => ({
value: category.id,
text: category.name
}));
},
isCurrent() {
return this.current.category === this.index;
},
Expand Down
3 changes: 3 additions & 0 deletions client/src/models/annotations.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@ export default {
},
delete(id) {
return axios.delete(`${baseURL}${id}`);
},
update(id, newParams) {
return axios.put(`${baseURL}${id}`, newParams);
}
};
42 changes: 34 additions & 8 deletions client/src/views/Annotator.vue
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@
:simplify="simplify"
:categorysearch="search"
:category="category"
:all-categories="categories"
:opacity="shapeOpacity"
:hover="hover"
:index="index"
Expand Down Expand Up @@ -202,7 +203,6 @@
<span aria-hidden="true">&times;</span>
</button>
</div>

</div>
</template>

Expand Down Expand Up @@ -730,20 +730,23 @@ export default {
category.showAnnotations = false;
});
},

addAnnotation(category, segments, keypoints) {
findCategoryByName(categoryName) {
let categoryComponent = this.$refs.category.find(
category =>
category.category.name.toLowerCase() === categoryName.toLowerCase()
);
if (!categoryComponent) return null;
return categoryComponent.category;
},
addAnnotation(categoryName, segments, keypoints) {
segments = segments || [];
keypoints = keypoints || [];

if (keypoints.length == 0 && segments.length == 0) return;

category = this.$refs.category.find(
c => c.category.name.toLowerCase() === category.toLowerCase()
);
let category = this.findCategoryByName(categoryName);
if (category == null) return;

category = category.category;

Annotations.create({
image_id: this.image.id,
category_id: category.id,
Expand All @@ -755,6 +758,29 @@ export default {
});
},

updateAnnotationCategory(annotation, oldCategory, newCategoryName) {
const newCategory = this.findCategoryByName(newCategoryName);
if (!newCategory || !annotation) return;

Annotations.update(annotation.id, { category_id: newCategory.id }).then(
response => {
let newAnnotation = {
...response.data,
...annotation,
metadata: response.data.metadata,
category_id: newCategory.id
};

if (newAnnotation) {
oldCategory.annotations = oldCategory.annotations.filter(
a => a.id !== annotation.id
);
newCategory.annotations.push(newAnnotation);
}
}
);
},

removeFromAnnotatingList() {
if (this.user == null) return;

Expand Down