[general] Write overwriting files in terms of .exists()

[jschneier]

Follow upstream and write the file overwriting handling in terms of exists().

Reference: django/django@0b33a3a#diff-63fca472a0ca8c04505cb4ec9c132663ac71fc964110afc8ae9218416f37821cR195-R202

[mikicz]

Btw found it very confusing that this change was not in the changelog!

[CorentinGoodays]

I noticed the change where exists() now always returns False when allow_overwrite=True. I’m curious about the rationale behind this decision, as I often rely on the exists() method for troubleshooting storage issues to check whether a blob already exists.

With this new behavior, how would you recommend handling such cases when allow_overwrite=True? Is there an alternative approach you had in mind for checking the existence of files under this setting?

Thanks in advance for the clarification!

[stuarta0]

@CorentinGoodays looks like the behaviour should be walked back in django-storages. See:

• New behaviour of S3 storage exists() breaks current workflow #1430
• Getting "The file could not be found" when using S3ManifestStaticStorage #1440 (comment)
• https://code.djangoproject.com/ticket/35604
• django/django@8d6a20b

[jschneier]

Indeed, the intent is to walk back the behavior which is why no new version has been released. If someone wants to submit a patch that fixes this for all backends and doesn't introduce a security vulnerability (following Django's lead most likely) then I would happily merge.