Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use extras_require in setup for backend dependencies -- take II #417

Merged
merged 4 commits into from
Mar 7, 2018

Conversation

browniebroke
Copy link
Contributor

Taking over work from #274, which appear abandoned and addressing the comments from the code review there. I've tried to update that pull request, but getting it merged requires action from the original contributor @mbarrien.

@codecov-io
Copy link

codecov-io commented Feb 7, 2018

Codecov Report

Merging #417 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   76.03%   76.03%           
=======================================
  Files          11       11           
  Lines        1573     1573           
=======================================
  Hits         1196     1196           
  Misses        377      377
Impacted Files Coverage Δ
storages/backends/ftp.py 90% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4dbf75...edbe71b. Read the comment docs.

mbarrien and others added 4 commits March 7, 2018 17:25
@browniebroke
Copy link
Contributor Author

Any chance we could get this merged @jleclanche ?

It's fixing the build as well as adding a nice new way to install the package once the next release is out. I depend on boto3 only through django-storages, would be nicer to install it as extra...

@jleclanche
Copy link
Contributor

py33 is not supported anymore, but ok

@jleclanche jleclanche merged commit c3b2446 into jschneier:master Mar 7, 2018
@browniebroke browniebroke deleted the patch-1 branch October 19, 2021 22:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants