Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[azure] Add method to set ContentDisposition #898

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

drnextgis
Copy link
Contributor

So far we couldn't do that.

@drnextgis drnextgis force-pushed the azure-content-disposition branch from a9dfef5 to 7d537f6 Compare June 14, 2020 21:04
@jschneier
Copy link
Owner

Can you add something similar to get_object_parameters. Probably should have been a little smarter about the name so it would be consistent across backends...you could just call it get_object_parameters.

@drnextgis drnextgis force-pushed the azure-content-disposition branch from 7d537f6 to 34e396d Compare June 15, 2020 06:42
@drnextgis drnextgis force-pushed the azure-content-disposition branch from 34e396d to cb9be6e Compare June 15, 2020 06:45
@drnextgis
Copy link
Contributor Author

@jschneier thanks for the prompt reply. Done and rebased.

@drnextgis
Copy link
Contributor Author

Hey, should I do something else to have it being merged?

@jschneier jschneier merged commit 3fbad31 into jschneier:master Dec 15, 2020
@drnextgis drnextgis deleted the azure-content-disposition branch December 15, 2020 20:14
@JeffreyCA
Copy link
Contributor

Thank you for this! For future reference, the accepted key values for AZURE_OBJECT_PARAMETERS are: content_type, content_encoding, content_language, content_disposition, cache_control, and content_md5.

mlazowik pushed a commit to qedsoftware/django-storages that referenced this pull request Mar 9, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants