use encryption setting for S3BotoStorageFile multipart uploads #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jschneier do you mind taking a look when you have a moment? Thank you! |
|
This looks good, thanks. |
jschneier
added a commit
that referenced
this pull request
Nov 16, 2015
use encryption setting for S3BotoStorageFile multipart uploads
jschneier
added a commit
that referenced
this pull request
Nov 16, 2015
mbarrien
added a commit
to mbarrien/django-storages
that referenced
this pull request
Jan 13, 2016
This was referenced Jul 27, 2016
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3BotoStorageFile's write method was not initiating the multipart upload with encryption on, even when
AWS_S3_ENCRYPTIONwas True in the settings