Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Check for misspelled blueOak categories #87

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Check for misspelled blueOak categories #87

merged 1 commit into from
Dec 1, 2022

Conversation

ericcornelissen
Copy link
Contributor

Closes #46

Adds a new check to the validConfiguration function that validates the provided blueOak string is a valid blueOak category. Also added a test for this case.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

index.js Outdated Show resolved Hide resolved
@kemitchell
Copy link
Member

@ericcornelissen do you license these contribs under Apache 2.0?

@ericcornelissen
Copy link
Contributor Author

@kemitchell, yes

@kemitchell
Copy link
Member

Thanks!

@kemitchell kemitchell merged commit d44aa11 into jslicense:main Dec 1, 2022
@ericcornelissen ericcornelissen deleted the 46-validate-blueoak branch December 1, 2022 21:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When misspelling the blueOak category name, it doesn't warn me
3 participants