Skip to content

Show suggestion for "Local function can be made static" in IDE #1473

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

bkoelman
Copy link
Member

Resharper: "Local function can be made static" is at warning level in cibuild, but was turned off in IDE. This fixes the mismatch reported at #1466 (comment).

We haven't used local functions much in the codebase before, which is why this mismatch went unnoticed until now.

QUALITY CHECKLIST

  • N/A: Changes implemented in code
  • Complies with our contributing guidelines
  • N/A: Adapted tests
  • N/A: Documentation updated

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be6decc) 90.74% compared to head (3f50ce3) 90.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1473   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files         344      344           
  Lines       11002    11002           
  Branches     1811     1804    -7     
=======================================
  Hits         9984     9984           
  Misses        669      669           
  Partials      349      349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review February 21, 2024 06:09
@bkoelman bkoelman merged commit d1707ef into master Feb 21, 2024
@bkoelman bkoelman deleted the show-static-local-function-suggestion branch February 21, 2024 06:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant