fix: remove unnecessary schema from require-render-return #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jul 3, 2019
| @@ -21,7 +21,7 @@ module.exports = { | |||
| recommended: true, | |||
| url: docsUrl('require-render-return') | |||
| }, | |||
| schema: [{}] | |||
| schema: [] | |||
There was a problem hiding this comment.
this seems like it'd be a breaking change, in case someone had already been providing an empty object.
There was a problem hiding this comment.
it technically would be breaking in the strictest sense.
Though reviewing the history, this has been an empty object for 3 years, so I doubt there's some legacy config people have left over.
The problem is that this schema value doesn't just allow an empty object, it allows literally value.
There was a problem hiding this comment.
yes - i agree that's a problem, however, that means that removing this would cause eslint to crash on a config that was previously working :-/
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there was a schema defining an empty object - it's an unnecessary definition, so remove it.