-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Fix] jsx-no-leaked-render
: preserve RHS parens for multiline jsx element while fixing
#3623
Merged
ljharb
merged 1 commit into
jsx-eslint:master
from
akulsr0:fix/excessive-code-changes-no-leaked-render
Aug 25, 2023
Merged
[Fix] jsx-no-leaked-render
: preserve RHS parens for multiline jsx element while fixing
#3623
ljharb
merged 1 commit into
jsx-eslint:master
from
akulsr0:fix/excessive-code-changes-no-leaked-render
Aug 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lements while fixing
Codecov Report
@@ Coverage Diff @@
## master #3623 +/- ##
==========================================
- Coverage 97.64% 94.35% -3.29%
==========================================
Files 132 132
Lines 9351 9358 +7
Branches 3423 3425 +2
==========================================
- Hits 9131 8830 -301
- Misses 220 528 +308
|
ljharb
reviewed
Aug 25, 2023
ljharb
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
2428d4c
to
422ff33
Compare
This was referenced May 24, 2024
This was referenced Jun 18, 2024
This was referenced Oct 4, 2024
This was referenced Oct 4, 2024
This was referenced Oct 4, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3551