Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] jsx-no-leaked-render: preserve RHS parens for multiline jsx element while fixing #3623

Merged

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented Aug 25, 2023

Fixes #3551

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #3623 (2428d4c) into master (dd6e05c) will decrease coverage by 3.29%.
The diff coverage is 100.00%.

❗ Current head 2428d4c differs from pull request most recent head 422ff33. Consider uploading reports for the commit 422ff33 to get more accurate results

@@            Coverage Diff             @@
##           master    #3623      +/-   ##
==========================================
- Coverage   97.64%   94.35%   -3.29%     
==========================================
  Files         132      132              
  Lines        9351     9358       +7     
  Branches     3423     3425       +2     
==========================================
- Hits         9131     8830     -301     
- Misses        220      528     +308     
Files Changed Coverage Δ
lib/rules/jsx-no-leaked-render.js 98.86% <100.00%> (+0.09%) ⬆️

... and 16 files with indirect coverage changes

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ljharb ljharb force-pushed the fix/excessive-code-changes-no-leaked-render branch from 2428d4c to 422ff33 Compare August 25, 2023 16:11
@ljharb ljharb merged commit 422ff33 into jsx-eslint:master Aug 25, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Excessive code changes done by --fix react/jsx-no-leaked-render
2 participants