Skip to content

[New] forbid-dom-props: Add disallowedValues option for forbidden props #3877

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[New] forbid-dom-props: Add disallowedValues option for forbidden props #3877

wants to merge 1 commit into from
+268 −9

Conversation

makxca
Copy link

@makxca makxca commented Jan 11, 2025 •
edited
Loading

Add disallowedValues for disallowing only certain values for certain props

Discussion: #3876

@codecov Codecov
Copy link

codecov bot commented Jan 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (efc021f) to head (a2e9dac).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3877      +/-   ##
==========================================
+ Coverage   97.64%   97.66%   +0.02%     
==========================================
  Files         133      136       +3     
  Lines        9966     9986      +20     
  Branches     3703     3706       +3     
==========================================
+ Hits         9731     9753      +22     
+ Misses        235      233       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb ljharb marked this pull request as draft January 12, 2025 00:27
ljharb
ljharb requested changes Jan 12, 2025
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a regex is a nonstarter; see #3876 (comment)

@makxca makxca force-pushed the master branch 2 times, most recently from a7911e2 to d52c0f1 Compare January 12, 2025 21:53
@makxca makxca marked this pull request as ready for review January 12, 2025 21:53
@makxca makxca force-pushed the master branch 2 times, most recently from de2e1ea to 5d3d27c Compare January 13, 2025 07:30
@makxca makxca changed the title [New] forbid-dom-props: Add valueRegex option for forbidden props [New] forbid-dom-props: Add disallowedValues option for forbidden props Jan 13, 2025
@makxca makxca requested a review from ljharb January 13, 2025 19:44
@makxca
Copy link
Author

makxca commented Jan 13, 2025 •
edited
Loading

I changed valueRegex to disallowedValues and fixed the comma in the docs

@makxca
Copy link
Author

makxca commented Mar 27, 2025 •
edited
Loading

@ljharb, hello!

Opensource is practically new to me. Could you please guide me on this PR's flow? When can it be merged?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ljharb ljharb Awaiting requested review from ljharb

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makxca @ljharb