Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ENH]: Add feature_md5 argument to read_transform() #248

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

synchon
Copy link
Member

@synchon synchon commented Aug 3, 2023

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR adds feature_md5 argument to junifer.onthefly.read_transform() to allow accessing storage features by MD5 hashes.

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-08-03 10:27 UTC

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #248 (3f8febc) into main (dc23879) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files          84       84           
  Lines        3714     3714           
  Branches      722      722           
=======================================
  Hits         3458     3458           
  Misses        160      160           
  Partials       96       96           
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 93.10% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
junifer/onthefly/read_transform.py 93.75% <100.00%> (ø)

@synchon synchon added enhancement New feature or request ready Pull request is ready for review and merge labels Aug 3, 2023
@synchon synchon merged commit e3e9423 into main Aug 3, 2023
@synchon synchon deleted the update/read_transform_feature_md5 branch August 3, 2023 10:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request ready Pull request is ready for review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant