Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ENH]: Add support for native space #252

Merged
merged 13 commits into from
Oct 27, 2023
Merged

[ENH]: Add support for native space #252

merged 13 commits into from
Oct 27, 2023

Conversation

synchon
Copy link
Member

@synchon synchon commented Sep 27, 2023

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR provides support for converting to and operating on subject-native space.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #252 (dbbf651) into main (7688d2e) will decrease coverage by 0.42%.
The diff coverage is 32.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   90.37%   89.96%   -0.42%     
==========================================
  Files          89       89              
  Lines        4002     4026      +24     
  Branches      773      782       +9     
==========================================
+ Hits         3617     3622       +5     
- Misses        274      284      +10     
- Partials      111      120       +9     
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 89.96% <32.14%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
junifer/datagrabber/hcp1200/hcp1200.py 96.07% <60.00%> (-3.93%) ⬇️
junifer/datareader/default.py 96.07% <0.00%> (-3.93%) ⬇️
junifer/datagrabber/aomic/id1000.py 83.33% <28.57%> (-16.67%) ⬇️
junifer/datagrabber/aomic/piop1.py 88.00% <28.57%> (-9.73%) ⬇️
junifer/datagrabber/aomic/piop2.py 87.23% <28.57%> (-10.33%) ⬇️

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-27 09:55 UTC

Copy link
Contributor

@fraimondo fraimondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some more testing, but this is the most-likely definite codebase.

@synchon synchon force-pushed the feat/native-space-support branch from 375455f to 9366244 Compare October 6, 2023 16:39
@synchon synchon requested a review from fraimondo October 10, 2023 09:26
Copy link
Contributor

@fraimondo fraimondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs to be updated after #254 is merged.

@synchon synchon force-pushed the feat/native-space-support branch 2 times, most recently from f7f9e53 to 0a22f77 Compare October 16, 2023 09:42
@synchon synchon force-pushed the feat/native-space-support branch from 1c4139f to ed6f607 Compare October 17, 2023 09:47
@synchon synchon force-pushed the feat/native-space-support branch from ed6f607 to 2913a18 Compare October 25, 2023 16:09
@synchon synchon force-pushed the feat/native-space-support branch from 1ddde89 to da1b57d Compare October 26, 2023 13:42
@synchon synchon requested a review from fraimondo October 26, 2023 13:44
@synchon synchon merged commit 4f2772f into main Oct 27, 2023
@synchon synchon deleted the feat/native-space-support branch October 27, 2023 09:49
@synchon synchon added the enhancement New feature or request label Oct 31, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants