[ENH]: Specify which shell to use when using junifer queue

[synchon]

Are you requiring a new dataset or marker?

• I understand this is not a marker or dataset request

Which feature do you want to include?

I would like to be able to specify the shell that junifer uses to submit jobs. For some reason when using bash I could not get jobs to work. When using zsh by manually changing it, it seemed to work (maybe something from with my bash environment, maybe magic or maybe coincidence). Either way I think this could be a desirable feature. What do you think?

How do you imagine this integrated in junifer?

as a param that prints different text

Do you have a sample code that implements this outside of junifer?

No response

Anything else to say?

No response

[synchon]

This could be quite useful in my opinion.

[synchon]

@LeSasse Can you check if the branch solves your issue?

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-09 12:13 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b0c0a61) to head (de69448).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #273   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

Flag	Coverage Δ
docs	100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[LeSasse]

@LeSasse Can you check if the branch solves your issue?

Will check it

[LeSasse]

@LeSasse Can you check if the branch solves your issue?

I think this branch needs a rebase: the dag files still use single quotes and submitting therefore fails.

[synchon]

@LeSasse Can you check if the branch solves your issue?

I think this branch needs a rebase: the dag files still use single quotes and submitting therefore fails.

I see that the quotes are proper in dag, can you try rebasing your local branch?

[LeSasse]

@LeSasse Can you check if the branch solves your issue?

I think this branch needs a rebase: the dag files still use single quotes and submitting therefore fails.

I see that the quotes are proper in dag, can you try rebasing your local branch?

thats quite odd because i actually cloned and checked out this branch just minutes before that comment, and after i rebased it locally it worked, but before, no.

Ah no, this was supposed to go on the other PR #161 so thats the one that would need rebasing

[LeSasse]

Tested this now and it works.