Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG]: Replace FSL std2imgcoord with img2imgcoord #281

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

synchon
Copy link
Member

@synchon synchon commented Dec 8, 2023

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR replaces FSL std2imgcoord with img2imgcoord as the former is incorrect for coordinates transformation to other template spaces.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #281 (2e1b3a4) into main (dbd03dd) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #281   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files          99       99           
  Lines        4390     4390           
  Branches      847      847           
=======================================
  Hits         3928     3928           
  Misses        321      321           
  Partials      141      141           
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 89.47% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
junifer/data/coordinates.py 70.76% <0.00%> (ø)

Copy link

github-actions bot commented Dec 8, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-12-08 11:16 UTC

@synchon synchon requested a review from fraimondo December 8, 2023 09:41
@synchon synchon added the enhancement New feature or request label Dec 8, 2023
Copy link
Contributor

@fraimondo fraimondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set it as a bugfix and not as an enhancement.

@synchon synchon added bug Something isn't working and removed enhancement New feature or request labels Dec 8, 2023
@synchon synchon changed the title [ENH]: Replace FSL std2imgcoord with img2imgcoord [BUG]: Replace FSL std2imgcoord with img2imgcoord Dec 8, 2023
@synchon synchon requested a review from fraimondo December 8, 2023 10:45
@synchon synchon merged commit 14f37e6 into main Dec 8, 2023
@synchon synchon deleted the update/replace-std2imgcoord-with-img2img2coord branch December 8, 2023 11:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants