[MAINT]: Update dependencies #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1 1
=========================================
Hits 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
1 task
fraimondo
reviewed
Jun 18, 2024
| @@ -104,7 +104,7 @@ def _apply_mask_and_get_affinity( | |||
|
|
|||
| # Compute world coordinates of all in-mask voxels. | |||
| if niimg is None: | |||
| mask, affine = masking._load_mask_img(mask_img) | |||
| mask, affine = masking.load_mask_img(mask_img) | |||
There was a problem hiding this comment.
so thanks to this we stop supporting nilearn 0.9?
There was a problem hiding this comment.
Yeah till 0.12 because of this and a few others.
fraimondo
approved these changes
Jun 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates core and docs dependencies to benefit from improvements in different libraries.