-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[ENH]: Introduce JuniferConnectivityMeasure
#348
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 88.58% 88.67% +0.08%
==========================================
Files 114 115 +1
Lines 5028 5138 +110
Branches 983 1019 +36
==========================================
+ Hits 4454 4556 +102
- Misses 418 422 +4
- Partials 156 160 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
2d20601
to
b837fc1
Compare
fraimondo
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will require a new major I think.
a0c23d8
to
c92a1a7
Compare
edb210e
to
767d14f
Compare
…ConnectivityMeasure
9d20190
to
6b792b9
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
JuniferConnectivityMeasure
, tailorednilearn.connectome.ConnectivityMeasure
for junifer. This setssklearn.covariance.EmpiricalCovariance
as the default covariance estimator andcorrelation
as the default connectivity matrix kind, which is what junifer users mostly do. It also sets the ground to add custom connectivity matrix kinds and correlation metrics. Required by #333 and #335 as of now.