Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ENH]: Adapt MultipleDataGrabber to patterns with nested data types #351

Merged
merged 20 commits into from
Jul 19, 2024

Conversation

synchon
Copy link
Member

@synchon synchon commented Jul 12, 2024

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR refactors MultipleDataGrabber to adapt it to updated DataGrabber patterns with nested data types.

@synchon synchon added the dataset Issues or pull requests related to datagrabbers or datasets label Jul 12, 2024
@synchon synchon added this to the 0.0.5 (alpha 4) milestone Jul 12, 2024
Copy link

github-actions bot commented Jul 12, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-19 11:32 UTC

@synchon synchon requested a review from fraimondo July 12, 2024 06:10
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 12 lines in your changes missing coverage. Please review.

Project coverage is 88.56%. Comparing base (e016a7d) to head (f2d8d08).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   88.67%   88.56%   -0.11%     
==========================================
  Files         115      115              
  Lines        5138     5178      +40     
  Branches     1019     1034      +15     
==========================================
+ Hits         4556     4586      +30     
- Misses        422      426       +4     
- Partials      160      166       +6     
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 88.56% <89.65%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
junifer/datagrabber/__init__.py 100.00% <100.00%> (ø)
junifer/datagrabber/hcp1200/hcp1200.py 100.00% <100.00%> (ø)
junifer/utils/__init__.py 100.00% <100.00%> (ø)
junifer/utils/helpers.py 100.00% <100.00%> (ø)
junifer/utils/logging.py 73.58% <100.00%> (+1.58%) ⬆️
junifer/datagrabber/pattern.py 96.69% <83.33%> (-1.56%) ⬇️
junifer/datagrabber/pattern_validation_mixin.py 96.96% <96.96%> (ø)
junifer/datagrabber/base.py 91.80% <0.00%> (-6.51%) ⬇️
junifer/datagrabber/multiple.py 91.37% <73.33%> (-6.50%) ⬇️

@synchon synchon force-pushed the fix/multiple-dg-access branch 3 times, most recently from e169244 to 41327b2 Compare July 18, 2024 10:32
@synchon synchon force-pushed the fix/multiple-dg-access branch from 6936632 to f2d8d08 Compare July 19, 2024 10:08
@fraimondo fraimondo merged commit 64121e3 into main Jul 19, 2024
26 of 28 checks passed
@fraimondo fraimondo deleted the fix/multiple-dg-access branch July 19, 2024 11:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dataset Issues or pull requests related to datagrabbers or datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants