Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

text-embeddings-inference-cpu temp fix for Apple Silicon CPUs #480

Merged

Conversation

HamadaSalhab
Copy link
Contributor

@HamadaSalhab HamadaSalhab commented Aug 30, 2024

Description:

  • Added linux/amd64 platform to text-embeddings-inference-cpu service in agents_api/agents-api/docker-compose.yml.

🚀 This description was created by Ellipsis for commit 37922d1

Summary:

Added platform: linux/amd64 to text-embeddings-inference-cpu in agents-api/docker-compose.yml to fix compatibility with Mac M-series CPUs.

Key points:

  • Added platform: linux/amd64 to text-embeddings-inference-cpu service in agents-api/docker-compose.yml.
  • This change is a temporary fix for compatibility issues with Mac M-series chips.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 37922d1 in 5 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/docker-compose.yml:105
  • Draft comment:
    Consider documenting this temporary fix in a more permanent location, such as a README or a comment in the codebase, to ensure future developers are aware of the reason for this change and can address it if necessary.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The addition of the platform specification is a temporary fix for compatibility with Mac M-series chips. This is a valid change given the context provided in the PR description.

Workflow ID: wflow_kktqaWDf43axfQKA


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit f8d32e4 into dev-tasks Sep 2, 2024
2 of 5 checks passed
@creatorrr creatorrr deleted the x/fix-text-embeddings-inference-cpu-mac-m-series branch September 2, 2024 23:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants