Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add docker bake builder #528

Merged
merged 2 commits into from
Sep 28, 2024
Merged

feat: Add docker bake builder #528

merged 2 commits into from
Sep 28, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Sep 28, 2024

Signed-off-by: Diwank Singh Tomer diwank.singh@gmail.com


Important

Introduce Docker Bake for building and pushing images with updated GitHub Actions workflows and Dockerfiles.

  • GitHub Actions Workflows:
    • Add .github/workflows/dev-push-to-hub.yml and .github/workflows/main-push-to-hub.yml for building and pushing images on dev and main branch merges.
    • Remove push-to-hub.yml workflow.
  • Docker Build System:
    • Introduce docker-bake.hcl for defining Docker build targets and configurations.
    • Update Dockerfiles in agents-api, agents-api.worker, agents-api.migration to use Docker Bake.
  • Documentation:
    • Update CONTRIBUTING.md with instructions for building Docker images using Docker Bake.
  • Miscellaneous:
    • Add submodules for sdks/node-sdk and sdks/python-sdk.

This description was created by Ellipsis for 2a82893. It will automatically update as commits are pushed.

Signed-off-by: Diwank Singh Tomer <diwank.singh@gmail.com>
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to bbbd6cf in 23 seconds

More details
  • Looked at 629 lines of code in 16 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. docker-bake.hcl:72
  • Draft comment:
    Add a newline at the end of the file for better compatibility with various tools and systems.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The docker-bake.hcl file is missing a newline at the end. This is a minor issue but it's a good practice to ensure files end with a newline for compatibility with various tools and systems.
2. gateway/Dockerfile:14
  • Draft comment:
    Consider upgrading to Traefik v3 as noted in the TODO comment for future compatibility and features.
  • Reason this comment was not posted:
    Confidence changes required: 30%
    The gateway/Dockerfile has a TODO comment about upgrading to Traefik v3. This is not an immediate issue but should be tracked for future updates.

Workflow ID: wflow_soCgzvITGBIvWhhM


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Signed-off-by: Diwank Singh Tomer <diwank.singh@gmail.com>
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 2a82893 in 7 seconds

More details
  • Looked at 16 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/Dockerfile:16
  • Draft comment:
    The removal of the second poetry install --no-dev command is correct as it was redundant. This change improves the Dockerfile by eliminating unnecessary steps.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The removal of the second poetry install --no-dev command is correct as it was redundant.

Workflow ID: wflow_4BBmLicWBzz0R8Tz


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit 5060ee3 into dev Sep 28, 2024
4 of 5 checks passed
@creatorrr creatorrr deleted the f/docker-build branch September 28, 2024 15:50
creatorrr added a commit that referenced this pull request Sep 28, 2024
Vedantsahai18 pushed a commit that referenced this pull request Sep 28, 2024
Introduce Docker Bake for building and pushing images with updated GitHub Actions workflows and Dockerfiles.

  - **GitHub Actions Workflows**:
    - Add `.github/workflows/dev-push-to-hub.yml` and `.github/workflows/main-push-to-hub.yml` for building and pushing images on `dev` and `main` branch merges.
    - Remove `push-to-hub.yml` workflow.
  - **Docker Build System**:
    - Introduce `docker-bake.hcl` for defining Docker build targets and configurations.
    - Update Dockerfiles in `agents-api`, `agents-api.worker`, `agents-api.migration` to use Docker Bake.
  - **Documentation**:
    - Update `CONTRIBUTING.md` with instructions for building Docker images using Docker Bake.
  - **Miscellaneous**:
    - Add submodules for `sdks/node-sdk` and `sdks/python-sdk`.
creatorrr added a commit that referenced this pull request Sep 30, 2024
Introduce Docker Bake for building and pushing images with updated GitHub Actions workflows and Dockerfiles.

  - **GitHub Actions Workflows**:
    - Add `.github/workflows/dev-push-to-hub.yml` and `.github/workflows/main-push-to-hub.yml` for building and pushing images on `dev` and `main` branch merges.
    - Remove `push-to-hub.yml` workflow.
  - **Docker Build System**:
    - Introduce `docker-bake.hcl` for defining Docker build targets and configurations.
    - Update Dockerfiles in `agents-api`, `agents-api.worker`, `agents-api.migration` to use Docker Bake.
  - **Documentation**:
    - Update `CONTRIBUTING.md` with instructions for building Docker images using Docker Bake.
  - **Miscellaneous**:
    - Add submodules for `sdks/node-sdk` and `sdks/python-sdk`.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant