fix char parsing #283

pfitzseb · 2021-06-07T10:29:46Z

For every PR, please check the following:

End-user documentation check. If this PR requires end-user documentation in the Julia VS Code extension docs, please add that at https://github.com/julia-vscode/docs.
Changelog mention. If this PR should be mentioned in the CHANGELOG for the Julia VS Code extension, please open a PR against https://github.com/julia-vscode/julia-vscode/blob/master/CHANGELOG.md with those changes.

davidanthoff · 2021-06-07T17:26:56Z

Hm, this seems to not work on Julia 1.0?

davidanthoff

There are a lot of whitespace changes in here as well? No problem, but maybe there is a setting that would avoid that?

pfitzseb · 2021-06-07T17:49:41Z

Yes, but I like my files better without trailing whitespace ;)

pfitzseb · 2021-06-09T18:13:45Z

Turns out our string parsing was broken in the presence of invalid escape sequences in strings, so this PR fixes that as well.

fix char parsing

907cceb

pfitzseb requested a review from a team June 7, 2021 10:29

davidanthoff added the bug label Jun 7, 2021

davidanthoff previously approved these changes Jun 7, 2021

View reviewed changes

davidanthoff added this to the Next Patch milestone Jun 7, 2021

fix for Julia 1.0

550f0b6

pfitzseb dismissed davidanthoff’s stale review via 550f0b6 June 7, 2021 17:31

davidanthoff previously approved these changes Jun 7, 2021

View reviewed changes

fix octal char parsing

c2cd117

pfitzseb dismissed davidanthoff’s stale review via c2cd117 June 8, 2021 08:16

pfitzseb added 4 commits June 8, 2021 11:45

fix CI?

c5bce50

make string parsing more robust

6ad4e5f

string parsing test

54c3f7a

fix test

26d3bb5

pfitzseb requested a review from davidanthoff June 9, 2021 18:11

davidanthoff approved these changes Jun 9, 2021

View reviewed changes

davidanthoff merged commit 6154d19 into master Jun 9, 2021

davidanthoff deleted the sp/fix-char-parsing branch June 9, 2021 20:22

Provide feedback