Fix macro calls with argument lists #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 82.57% 82.56% -0.02%
==========================================
Files 26 26
Lines 2273 2260 -13
==========================================
- Hits 1877 1866 -11
+ Misses 396 394 -2
Continue to review full report at Codecov.
|
ZacLN
requested changes
Aug 2, 2017
src/CSTParser.jl
Outdated
| @@ -200,7 +200,7 @@ item so surrounding punctuation must be handled externally. | |||
| **NOTE** | |||
src/components/macros.jl
Outdated
| @@ -52,7 +52,7 @@ function parse_macrocall(ps::ParseState) | |||
| if isemptyws(ps.ws) && ps.nt.kind == Tokens.LPAREN | |||
| next(ps) | |||
| push!(ret.args, INSTANCE(ps)) | |||
| @catcherror ps startbyte args = @default ps @nocloser ps newline @closer ps paren parse_list(ps, ret.args) | |||
| @catcherror ps startbyte args = @default ps @nocloser ps newline @closer ps paren parse_list(ps) | |||
There was a problem hiding this comment.
use parse_comma_sep(ps, ret, false) and delete the trailing append! call
The commas would end up out of order with the rest of the arguments.
ZacLN
approved these changes
Aug 2, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commas would end up out of order with the rest of the arguments.