Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Meal Plan tests #1378

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Meal Plan tests #1378

merged 2 commits into from
Jul 13, 2024

Conversation

UlianaPurtova
Copy link
Contributor

part 1 of unit tests for meal plan

@julianpoy
Copy link
Owner

julianpoy commented Jun 5, 2024

If you wouldn't mind for both this PR and the other - it'd be useful to create a method for creating extra users, rather than calling setup again.

@UlianaPurtova
Copy link
Contributor Author

If you wouldn't mind for both this PR and the other - it'd be useful to create a method for creating extra users, rather than calling setup again.

hi @julianpoy , sorry it took me a bit long to get back
could you clarify how do you see this?
Because technically I already do have a method to specifically create an extra user and a session, they are exported
it's just it's convenient to call trpcSetup to do all of these things for me at once

maybe I should rename a function for a better name or make the trpcSetup take an optional argument to create an extra user at one go?
like trpcSetup(setupExtraUser = false )

thank you!

@julianpoy
Copy link
Owner

No worries, sorry for the delay in getting back to you as well!

like trpcSetup(setupExtraUser = false )

That'd be great, yeah! There are a lot of scenarios that require testing multiple users, so perhaps just creating two users by default would be good, even if both are not used in all tests.

@julianpoy
Copy link
Owner

I'm going to go ahead and merge this and you are welcome to follow up in a new PR with the changes discussed

@julianpoy julianpoy merged commit 0c9438a into julianpoy:master Jul 13, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants